Allow custom predicate that replaces StringReader#isAllowedInUnquotedString
#145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will cause problems when dealing with larger whitelists/list of allowed chars, therefor consider merging yours and #131's way of dealing with this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of #131 with greedy charset solution, I tried another approach that allows users to define their own whitelist. It might be useful when users trying to define their own syntax on command arguments like entity selectors or something else that might accept non-ASCII characters
Usage of
StringReader#readStringorStringReader#readUnquotedStringwithout any argument would lead to the default behavior, which is callingStringReader#isAllowedInUnquotedStringas their whitelist predicate.Fix #103.